jwt: fix signing issue when using bun runtime (fixes #462) #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? @jsanford8 @JacquiManzi We're experiencing the same issue internally - everything works on our API but the signing part. Submitted a ticket as well, looking forward for a new release with the included fix :) |
|
Hey @krzkz94 - sorry about the delay here! Could you add the specific changes to the base one, as well, so I can see the difference? As you say, if this is safe for node, I'd rather get this in to the core, but due to how this is built I'll need to merge this into a different branch first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462
This change is modeled after the Deno jwt shim which is similar. It might also make sense to just apply these changes to the jwt-node shim since they should be safe for either Bun or Node, but making this specific to Bun seems like a reasonable way to fix this for now.
I verified this fix manually for my use case, but we should probably add tests for Bun to make sure that this doesn't break in the future.